MartinKanters commented on a change in pull request #287: [MNG-6065] - Log
fail-level option.
URL: https://github.com/apache/maven/pull/287#discussion_r353943093
##########
File path: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
##########
@@ -541,6 +543,18 @@ else if ( cliRequest.commandLine.hasOption(
CLIManager.BATCH_MODE )
plexusLoggerManager = new Slf4jLoggerManager();
slf4jLogger = slf4jLoggerFactory.getLogger( this.getClass().getName()
);
+
+ if ( cliRequest.commandLine.hasOption( CLIManager.FAIL_LEVEL ) )
+ {
+ String logLevelThreshold = cliRequest.commandLine.getOptionValue(
CLIManager.FAIL_LEVEL );
+
+ if ( slf4jLoggerFactory instanceof MavenSlf4jWrapperFactory )
Review comment:
Good points, will add some logging on both if-statements!
Edit: Actually I think it makes more sense to only log it once, when parsing
the --fail-level flag. I asumme that if we log there that the flag will not
take into effect it would be clear enough to the user.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
