MartinKanters commented on a change in pull request #287: [MNG-6065] - Log fail-level option. URL: https://github.com/apache/maven/pull/287#discussion_r351494913
########## File path: maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenFailLevelLoggerState.java ########## @@ -19,29 +19,32 @@ * under the License. */ -import org.slf4j.Logger; +import org.slf4j.event.Level; /** - * MavenSimpleLoggerFactory + * Responsible for keeping state of whether the threshold of the --fail-level flag has been hit. */ -public class MavenSimpleLoggerFactory - extends SimpleLoggerFactory +class MavenFailLevelLoggerState Review comment: I guess GitHub messed up the diff, I can't explain the renaming otherwise. -- I like the name LogLevelRecorder, but currently it also holds state whether the threshold has been hit, so it might not fully describe it's intention. What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
