[ 
https://issues.apache.org/jira/browse/SUREFIRE-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980731#comment-16980731
 ] 

Tibor Digana commented on SUREFIRE-1724:
----------------------------------------

> The JUnit platform identifies tests by a UniqueId.

This is exactly the reason why we have SUREFIRE-1535 for the TestNG and JUnit5. 
And the communication channel with JSON is the prereq.

[~mpkorstanje]
Now i want to make sure that we are on the same line. Suppose we are forking 4 
JVMs. Using the test definition with e.g. packages:
1. shall we execute the packages across JVMs? or
2. shall we discover classes in packages and then fork them?

I guess the (1) but this has to be properly clarified in the documentation 
because this changes the mindset of every user.
Once we go for (1), the user should not expect making Surefire any classes 
discovery and their UniqueID. Anybody using the classes approach have to stick 
to inclussions/exclussions pattern or {{-Dtest=some/pkg/**/*Spec}} or the regex 
with multiple tests filtering.

> Support JUnit Platform DiscoverySelectors 
> ------------------------------------------
>
>                 Key: SUREFIRE-1724
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1724
>             Project: Maven Surefire
>          Issue Type: Improvement
>            Reporter: M.P. Korstanje
>            Priority: Major
>
> The JUnit Platform defines multiple 
> [DiscoverySelectors|https://junit.org/junit5/docs/5.0.2/api/org/junit/platform/engine/DiscoverySelector.html]
>  to discover tests in different locations. This allows TestEngines to 
> discover tests in classes, the class path root, resource root, files, ect.
> Currently Surefire supports TestEngine implementations  through the 
> JUnitPlatformProvider. However the JUnitPlatformProvider only issues 
> discovery requests for classes that have already been discovered by Surefire. 
> Additionally if no tests were discovered by Surefire then no test discovery 
> requests will be issued at all.
> This means that Surefire does not fully utilize the discovery capabilities of 
> the JUnit Platform and makes it impossible to use the JUnitPlatformProvider 
> for test frameworks that do not have class based tests such as Cucumber.
> To make Cucumber work at the very least the class path root discovery 
> selector would have to be supported.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to