rfscholte commented on a change in pull request #275: [MNG-6729] 
StringSearchModelInterpolator introspects objects from Java API
URL: https://github.com/apache/maven/pull/275#discussion_r311754544
 
 

 ##########
 File path: maven-model-builder/pom.xml
 ##########
 @@ -84,6 +84,11 @@ under the License.
       <artifactId>xmlunit-matchers</artifactId>
       <scope>test</scope>
     </dependency>
+    <dependency>
 
 Review comment:
   Tibor, this is becoming a useless discussion. The only thing you wanted to 
do is verify a private Field, that's pure reflection. You don't need a library 
for that, but if you already have a library supporting that, just use that one.
   Mavens reputation of downloading the internet is because Maven made it maybe 
too easy too add dependencies. One should be critical for every dependency, 
hence in this case there's no need for powermock.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to