rfscholte commented on a change in pull request #275: [MNG-6729]
StringSearchModelInterpolator introspects objects from Java API
URL: https://github.com/apache/maven/pull/275#discussion_r311707612
##########
File path: maven-model-builder/pom.xml
##########
@@ -84,6 +84,11 @@ under the License.
<artifactId>xmlunit-matchers</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
Review comment:
Let's not use powermock to get access to Fields. I don't want to seduce
people to use powermock, in general it means your code is not good testable,
but that should be fixed with better code, not with powermock power.
I'm pretty sure we're already using some code for this, e.g. Reflector from
Plexus Utils.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
