[jira] [Updated] (MCHECKSTYLE-378) violationIgnore property is completely ignored during runtime

Wed, 24 Jul 2019 15:25:13 -0700 


     [ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex P updated MCHECKSTYLE-378:
-------------------------------
    Description: 
Whether in project properties or plugin configuration, the subject property is 
completely ignored and not even its default value is shown in debug output.

pom.xml:
{code:java}
  <properties>
...
    
<checkstyle.violation.ignore>LineLength,JavadocMethod,JavadocVariable,JavadocType,JavadocPackage,ParameterNumber</checkstyle.violation.ignore>
...
  </properties>
...
          <plugin>             
            <groupId>org.apache.maven.plugins</groupId>             
            <artifactId>maven-checkstyle-plugin</artifactId>             
            <version>${plugin.apache.maven-checkstyle.version}</version>        
     
            <configuration>
              
<violationIgnore>LineLength,JavadocMethod,JavadocVariable,JavadocType,JavadocPackage,ParameterNumber</violationIgnore>
            
            </configuration>
...
{code}
 

when running `> mvn -X checkstyle:checkstyle` have the following:
{code:java}
Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
2019-04-04T13:00:29-06:00) 
Maven home: /opt/maven 
Java version: 11.0.3, vendor: Oracle Corporation, runtime: 
/usr/lib/jvm/java-11-openjdk-11.0.3.7-0.el7_6.x86_64 
Default locale: en_US, platform encoding: ANSI_X3.4-1968 
OS name: "linux", version: "5.2.2-1.el7.elrepo.x86_64", arch: "amd64", family: 
"unix" 
[DEBUG] Created new class realm maven.api
...
[DEBUG] Goal: org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:checkstyle 
(default-cli) [DEBUG] Style: Regular [DEBUG] Configuration: <?xml version="1.0" 
encoding="UTF-8"?> 
<configuration> 
  <cacheFile default-value="${project.build.directory}/checkstyle-cachefile"/> 
  <checkstyleRulesHeader default-value="&lt;?xml 
version=&quot;1.0&quot;?&gt;&#10;&lt;!DOCTYPE module PUBLIC 
&quot;-//Checkstyle//DTD Checkstyle Configuration 1.3//EN&quot;&#10; 
&quot;https://checkstyle.org/dtds/configuration_1_3.dtd&quot;&gt;&#10;"/> 
  <configLocation 
default-value="sun_checks.xml">${checkstyle.config.location}</configLocation>
  <consoleOutput default-value="false">true</consoleOutput>
  <enableFilesSummary default-value="true">true</enableFilesSummary>
  <enableRSS default-value="true">${checkstyle.enable.rss}</enableRSS>
  <enableRulesSummary default-value="true">false</enableRulesSummary>
  <enableSeveritySummary default-value="true">true</enableSeveritySummary>
  <encoding default-value="${project.build.sourceEncoding}">UTF-8</encoding>
  <excludes>**/internal/**/*.*</excludes>
  <failsOnError default-value="false">true</failsOnError>
  <headerLocation 
default-value="LICENSE.txt">${checkstyle.header.file}</headerLocation>
  <includeResources 
default-value="true">${checkstyle.includeResources}</includeResources>
  <includeTestResources 
default-value="true">${checkstyle.includeTestResources}</includeTestResources>
  <includeTestSourceDirectory default-value="false"/>
  <includes default-value="**\/*.java">${checkstyle.includes}</includes>
  <inputEncoding 
default-value="${project.build.sourceEncoding}">${encoding}</inputEncoding>
  <linkXRef default-value="true">true</linkXRef>
  <omitIgnoredModules default-value="false">true</omitIgnoredModules>
  <outputDirectory default-value="${project.reporting.outputDirectory}"/>
  <outputEncoding 
default-value="${project.reporting.outputEncoding}">${outputEncoding}</outputEncoding>
  <outputFile 
default-value="${project.build.directory}/checkstyle-result.xml">${checkstyle.output.file}</outputFile>
  <outputFileFormat 
default-value="xml">${checkstyle.output.format}</outputFileFormat>
  <plugin default-value="${plugin}"/>
  <project default-value="${project}"/>
  <propertiesLocation>${checkstyle.properties.location}</propertiesLocation>
  
<resourceExcludes>LineLength,JavadocMethod,JavadocVariable,JavadocType,JavadocPackage,ParameterNumber</resourceExcludes>
  <resourceIncludes 
default-value="**/*.properties">${checkstyle.resourceIncludes}</resourceIncludes>
 
  <resources default-value="${project.resources}"/>
  <rulesFiles 
default-value="${project.build.directory}/checkstyle-rules.xml">${checkstyle.output.rules.file}</rulesFiles>
  <skip default-value="false">${checkstyle.skip}</skip>
  <suppressionsFileExpression 
default-value="checkstyle.suppressions.file">${checkstyle.suppression.expression}</suppressionsFileExpression>
  
<suppressionsLocation>${checkstyle.suppressions.location}</suppressionsLocation>
  <testResources default-value="${project.testResources}"/>
  <xrefLocation default-value="${project.reporting.outputDirectory}/xref"/> 
</configuration> 
[DEBUG] =======================================================================
{code}

  was:
Whether in project properties or plugin configuration, the subject property is 
completely ignored and not even its default value is shown in debug output.

pom.xml:
{code:java}
  <properties>
...
    
<checkstyle.violation.ignore>LineLength,JavadocMethod,JavadocVariable,JavadocType,JavadocPackage,ParameterNumber</checkstyle.violation.ignore>
...
  </properties>
...
          <plugin>             
            <groupId>org.apache.maven.plugins</groupId>             
            <artifactId>maven-checkstyle-plugin</artifactId>             
            <version>${plugin.apache.maven-checkstyle.version}</version>        
     
            <configuration>
              
<violationIgnore>LineLength,JavadocMethod,JavadocVariable,JavadocType,JavadocPackage,ParameterNumber</violationIgnore>
            
            </configuration>
...
{code}
 

when running `> mvn -X checkstyle:checkstyle` have the following:
{code:java}
Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
2019-04-04T13:00:29-06:00) 
Maven home: /opt/maven 
Java version: 11.0.3, vendor: Oracle Corporation, runtime: 
/usr/lib/jvm/java-11-openjdk-11.0.3.7-0.el7_6.x86_64 
Default locale: en_US, platform encoding: ANSI_X3.4-1968 
OS name: "linux", version: "5.2.2-1.el7.elrepo.x86_64", arch: "amd64", family: 
"unix" 
[DEBUG] Created new class realm maven.api
...
[DEBUG] Goal: org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:checkstyle 
(default-cli) [DEBUG] Style: Regular [DEBUG] Configuration: <?xml version="1.0" 
encoding="UTF-8"?> 
<configuration> 
  <cacheFile default-value="${project.build.directory}/checkstyle-cachefile"/> 
  <checkstyleRulesHeader default-value="&lt;?xml 
version=&quot;1.0&quot;?&gt;&#10;&lt;!DOCTYPE module PUBLIC 
&quot;-//Checkstyle//DTD Checkstyle Configuration 1.3//EN&quot;&#10; 
&quot;https://checkstyle.org/dtds/configuration_1_3.dtd&quot;&gt;&#10;"/> 
  <configLocation 
default-value="sun_checks.xml">${checkstyle.config.location}</configLocation>
  <consoleOutput default-value="false">true</consoleOutput>
  <enableFilesSummary default-value="true">true</enableFilesSummary>
  <enableRSS default-value="true">${checkstyle.enable.rss}</enableRSS>
  <enableRulesSummary default-value="true">false</enableRulesSummary>
  <enableSeveritySummary default-value="true">true</enableSeveritySummary>
  <encoding default-value="${project.build.sourceEncoding}">UTF-8</encoding>
  <excludes>**/internal/**/*.*</excludes>
  <failsOnError default-value="false">true</failsOnError>
  <headerLocation 
default-value="LICENSE.txt">${checkstyle.header.file}</headerLocation>
  <includeResources 
default-value="true">${checkstyle.includeResources}</includeResources>
  <includeTestResources 
default-value="true">${checkstyle.includeTestResources}</includeTestResources>
  <includeTestSourceDirectory default-value="false"/>
  <includes default-value="**\/*.java">${checkstyle.includes}</includes>
  <inputEncoding 
default-value="${project.build.sourceEncoding}">${encoding}</inputEncoding>
  <linkXRef default-value="true">true</linkXRef>
  <omitIgnoredModules default-value="false">true</omitIgnoredModules>
  <outputDirectory default-value="${project.reporting.outputDirectory}"/>
  <outputEncoding 
default-value="${project.reporting.outputEncoding}">${outputEncoding}</outputEncoding>
  <outputFile 
default-value="${project.build.directory}/checkstyle-result.xml">${checkstyle.output.file}</outputFile>
  <outputFileFormat 
default-value="xml">${checkstyle.output.format}</outputFileFormat>
  <plugin default-value="${plugin}"/>
  <project default-value="${project}"/>
  <propertiesLocation>${checkstyle.properties.location}</propertiesLocation> 
   
<resourceExcludes>LineLength,JavadocMethod,JavadocVariable,JavadocType,JavadocPackage,ParameterNumber</resourceExcludes>
  <resourceIncludes 
default-value="**/*.properties">${checkstyle.resourceIncludes}</resourceIncludes>
 
  <resources default-value="${project.resources}"/>
  <rulesFiles 
default-value="${project.build.directory}/checkstyle-rules.xml">${checkstyle.output.rules.file}</rulesFiles>
  <skip default-value="false">${checkstyle.skip}</skip>
  <suppressionsFileExpression 
default-value="checkstyle.suppressions.file">${checkstyle.suppression.expression}</suppressionsFileExpression>
  
<suppressionsLocation>${checkstyle.suppressions.location}</suppressionsLocation>
  <testResources default-value="${project.testResources}"/>
  <xrefLocation default-value="${project.reporting.outputDirectory}/xref"/> 
</configuration> 
[DEBUG] =======================================================================
{code}


> violationIgnore property is completely ignored during runtime
> -------------------------------------------------------------
>
>                 Key: MCHECKSTYLE-378
>                 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-378
>             Project: Maven Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 3.1.0
>            Reporter: Alex P
>            Priority: Blocker
>
> Whether in project properties or plugin configuration, the subject property 
> is completely ignored and not even its default value is shown in debug output.
> pom.xml:
> {code:java}
>   <properties>
> ...
>     
> <checkstyle.violation.ignore>LineLength,JavadocMethod,JavadocVariable,JavadocType,JavadocPackage,ParameterNumber</checkstyle.violation.ignore>
> ...
>   </properties>
> ...
>           <plugin>             
>             <groupId>org.apache.maven.plugins</groupId>             
>             <artifactId>maven-checkstyle-plugin</artifactId>             
>             <version>${plugin.apache.maven-checkstyle.version}</version>      
>        
>             <configuration>
>               
> <violationIgnore>LineLength,JavadocMethod,JavadocVariable,JavadocType,JavadocPackage,ParameterNumber</violationIgnore>
>             
>             </configuration>
> ...
> {code}
>  
> when running `> mvn -X checkstyle:checkstyle` have the following:
> {code:java}
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 
> 2019-04-04T13:00:29-06:00) 
> Maven home: /opt/maven 
> Java version: 11.0.3, vendor: Oracle Corporation, runtime: 
> /usr/lib/jvm/java-11-openjdk-11.0.3.7-0.el7_6.x86_64 
> Default locale: en_US, platform encoding: ANSI_X3.4-1968 
> OS name: "linux", version: "5.2.2-1.el7.elrepo.x86_64", arch: "amd64", 
> family: "unix" 
> [DEBUG] Created new class realm maven.api
> ...
> [DEBUG] Goal: 
> org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:checkstyle 
> (default-cli) [DEBUG] Style: Regular [DEBUG] Configuration: <?xml 
> version="1.0" encoding="UTF-8"?> 
> <configuration> 
>   <cacheFile 
> default-value="${project.build.directory}/checkstyle-cachefile"/> 
>   <checkstyleRulesHeader default-value="&lt;?xml 
> version=&quot;1.0&quot;?&gt;&#10;&lt;!DOCTYPE module PUBLIC 
> &quot;-//Checkstyle//DTD Checkstyle Configuration 1.3//EN&quot;&#10; 
> &quot;https://checkstyle.org/dtds/configuration_1_3.dtd&quot;&gt;&#10;"/> 
>   <configLocation 
> default-value="sun_checks.xml">${checkstyle.config.location}</configLocation>
>   <consoleOutput default-value="false">true</consoleOutput>
>   <enableFilesSummary default-value="true">true</enableFilesSummary>
>   <enableRSS default-value="true">${checkstyle.enable.rss}</enableRSS>
>   <enableRulesSummary default-value="true">false</enableRulesSummary>
>   <enableSeveritySummary default-value="true">true</enableSeveritySummary>
>   <encoding default-value="${project.build.sourceEncoding}">UTF-8</encoding>
>   <excludes>**/internal/**/*.*</excludes>
>   <failsOnError default-value="false">true</failsOnError>
>   <headerLocation 
> default-value="LICENSE.txt">${checkstyle.header.file}</headerLocation>
>   <includeResources 
> default-value="true">${checkstyle.includeResources}</includeResources>
>   <includeTestResources 
> default-value="true">${checkstyle.includeTestResources}</includeTestResources>
>   <includeTestSourceDirectory default-value="false"/>
>   <includes default-value="**\/*.java">${checkstyle.includes}</includes>
>   <inputEncoding 
> default-value="${project.build.sourceEncoding}">${encoding}</inputEncoding>
>   <linkXRef default-value="true">true</linkXRef>
>   <omitIgnoredModules default-value="false">true</omitIgnoredModules>
>   <outputDirectory default-value="${project.reporting.outputDirectory}"/>
>   <outputEncoding 
> default-value="${project.reporting.outputEncoding}">${outputEncoding}</outputEncoding>
>   <outputFile 
> default-value="${project.build.directory}/checkstyle-result.xml">${checkstyle.output.file}</outputFile>
>   <outputFileFormat 
> default-value="xml">${checkstyle.output.format}</outputFileFormat>
>   <plugin default-value="${plugin}"/>
>   <project default-value="${project}"/>
>   <propertiesLocation>${checkstyle.properties.location}</propertiesLocation>
>   
> <resourceExcludes>LineLength,JavadocMethod,JavadocVariable,JavadocType,JavadocPackage,ParameterNumber</resourceExcludes>
>   <resourceIncludes 
> default-value="**/*.properties">${checkstyle.resourceIncludes}</resourceIncludes>
>  
>   <resources default-value="${project.resources}"/>
>   <rulesFiles 
> default-value="${project.build.directory}/checkstyle-rules.xml">${checkstyle.output.rules.file}</rulesFiles>
>   <skip default-value="false">${checkstyle.skip}</skip>
>   <suppressionsFileExpression 
> default-value="checkstyle.suppressions.file">${checkstyle.suppression.expression}</suppressionsFileExpression>
>   
> <suppressionsLocation>${checkstyle.suppressions.location}</suppressionsLocation>
>   <testResources default-value="${project.testResources}"/>
>   <xrefLocation default-value="${project.reporting.outputDirectory}/xref"/> 
> </configuration> 
> [DEBUG] 
> =======================================================================
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to