[
https://issues.apache.org/jira/browse/MSHADE-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799401#comment-16799401
]
Markus Karg commented on MSHADE-313:
------------------------------------
[~khmarbaise] I will send the PR ASAP. :)
[~michael-o] What's broken is that the ServiceLoader won't be able to actually
instantiate the service in the dependency anymore, as its implementing classes
are optimized away due to missing hard class links in the original artifact.
> Less agressive <minimizeJar>
> ----------------------------
>
> Key: MSHADE-313
> URL: https://issues.apache.org/jira/browse/MSHADE-313
> Project: Maven Shade Plugin
> Issue Type: Improvement
> Affects Versions: 3.2.1
> Reporter: Markus Karg
> Priority: Major
>
> The maven shade plugin already does a great job in minimizing JAR size. For
> the majority of applications this is exactly what is needed.
> On the other hand there are some application areas where the algorithm is too
> agressive. One particular and rather frequently found case is the services
> API: ServiceLoader will ceise to work for minimized JARs since it is the
> prototype of the biggest "minimize-JAR-antipattern": String-to-class
> conversion.
> To make <minimizeJar> usable in such scenarios, there should be a set of
> options to enable the usual suspetcs (like ServiceLoader) to be detected.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
