cowwoc commented on a change in pull request #14: Exclude non-exported packages 
when Java Modules are present.
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/14#discussion_r243782806
 
 

 ##########
 File path: 
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
 ##########
 @@ -2015,6 +2013,17 @@ protected void executeReport( Locale unusedLocale )
         }
         setFJavadocVersion( new File( jExecutable ) );
 
+        List<String> packageNames;
 
 Review comment:
   I had to move these lines under `setFJavaVersion()` because 
`javadocRuntimeVersion` is not set before this point.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to