[
https://issues.apache.org/jira/browse/MWAR-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640815#comment-16640815
]
ASF GitHub Bot commented on MWAR-371:
-------------------------------------
khmarbaise commented on a change in pull request #1: [MWAR-371] - Overlays
break first-win rule for web resource with target path ending with '/'
URL: https://github.com/apache/maven-war-plugin/pull/1#discussion_r223189348
##########
File path: src/it/MWAR-371/pom.xml
##########
@@ -0,0 +1,25 @@
+<project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ <modelVersion>4.0.0</modelVersion>
+ <groupId>mwar371</groupId>
+ <artifactId>mwar371</artifactId>
+ <version>0.0.1-SNAPSHOT</version>
+ <packaging>pom</packaging>
+ <modules>
+ <module>generic</module>
+ <module>custom</module>
+ </modules>
+ <build>
+ <pluginManagement>
+ <plugins>
+ <plugin>
+
<artifactId>maven-war-plugin</artifactId>
+ <version>2.6</version>
+ <configuration>
Review comment:
Why defining an different version than you are build with this build?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Overlays break first-win rule for web resource with target path ending with
> '/'
> -------------------------------------------------------------------------------
>
> Key: MWAR-371
> URL: https://issues.apache.org/jira/browse/MWAR-371
> Project: Maven WAR Plugin
> Issue Type: Bug
> Components: overlay
> Affects Versions: 2.6
> Reporter: Michal Domagala
> Priority: Minor
> Labels: up-for-grabs
> Attachments: custom-0.0.1-SNAPSHOT.war, mwar371-20180905
>
>
> I have WAR 'generic' containing 2 files: x/a1.txt and x/a2.txt
> I have WAR 'custom' with two source files: src/main/custom/a1.txt and
> src/main/custom/a2.txt and settings:
> {code:xml}
> <artifactId>maven-war-plugin</artifactId>
> <configuration>
> <webResources>
> <webResource>
> <directory>src/main/custom</directory>
> <includes><include>a1.txt</include></includes>
> <targetPath>x/</targetPath>
> </webResource>
> <webResource>
> <directory>src/main/custom</directory>
> <includes><include>a2.txt</include></includes>
> <targetPath>x</targetPath>
> </webResource>
> </webResources>
> </configuration>
> {code}
> Note that *targetPath* is different: *x/* vs *x*
> When I build WAR 'custom'
> Actual: a1.txt is generic, a2.txt is custom
> Expected a1.txt and a2.txt are custom
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
