[
https://issues.apache.org/jira/browse/MNG-6475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613960#comment-16613960
]
ASF GitHub Bot commented on MNG-6475:
-------------------------------------
khmarbaise closed pull request #182: [MNG-6475] Remove unused Guava dependencies
URL: https://github.com/apache/maven/pull/182
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/maven-core/pom.xml b/maven-core/pom.xml
index 1f3dad5cc5..c34b7612e9 100644
--- a/maven-core/pom.xml
+++ b/maven-core/pom.xml
@@ -105,10 +105,6 @@ under the License.
<artifactId>guice</artifactId>
<classifier>no_aop</classifier>
</dependency>
- <dependency>
- <groupId>com.google.guava</groupId>
- <artifactId>guava</artifactId>
- </dependency>
<dependency>
<groupId>javax.inject</groupId>
<artifactId>javax.inject</artifactId>
diff --git a/maven-embedder/pom.xml b/maven-embedder/pom.xml
index ca9ca51f79..8f1799cc24 100644
--- a/maven-embedder/pom.xml
+++ b/maven-embedder/pom.xml
@@ -79,10 +79,6 @@ under the License.
<artifactId>guice</artifactId>
<classifier>no_aop</classifier>
</dependency>
- <dependency>
- <groupId>com.google.guava</groupId>
- <artifactId>guava</artifactId>
- </dependency>
<dependency>
<groupId>javax.inject</groupId>
<artifactId>javax.inject</artifactId>
diff --git a/maven-model-builder/pom.xml b/maven-model-builder/pom.xml
index 149f081511..d447d6c019 100644
--- a/maven-model-builder/pom.xml
+++ b/maven-model-builder/pom.xml
@@ -58,10 +58,6 @@ under the License.
<groupId>org.apache.maven</groupId>
<artifactId>maven-builder-support</artifactId>
</dependency>
- <dependency>
- <groupId>com.google.guava</groupId>
- <artifactId>guava</artifactId>
- </dependency>
<dependency>
<groupId>org.eclipse.sisu</groupId>
<artifactId>org.eclipse.sisu.plexus</artifactId>
diff --git a/pom.xml b/pom.xml
index 0143254a15..beced973e7 100644
--- a/pom.xml
+++ b/pom.xml
@@ -57,7 +57,6 @@ under the License.
<plexusVersion>1.7.1</plexusVersion>
<plexusInterpolationVersion>1.25</plexusInterpolationVersion>
<plexusUtilsVersion>3.1.0</plexusUtilsVersion>
- <guavaVersion>20.0</guavaVersion>
<guiceVersion>4.2.0</guiceVersion>
<sisuInjectVersion>0.3.3</sisuInjectVersion>
<wagonVersion>3.1.0</wagonVersion>
@@ -227,11 +226,6 @@ under the License.
<artifactId>plexus-utils</artifactId>
<version>${plexusUtilsVersion}</version>
</dependency>
- <dependency>
- <groupId>com.google.guava</groupId>
- <artifactId>guava</artifactId>
- <version>${guavaVersion}</version>
- </dependency>
<dependency>
<groupId>com.google.inject</groupId>
<artifactId>guice</artifactId>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove guava dependencies
> -------------------------
>
> Key: MNG-6475
> URL: https://issues.apache.org/jira/browse/MNG-6475
> Project: Maven
> Issue Type: Task
> Affects Versions: 3.6.0
> Reporter: Phillip Webb
> Assignee: Karl Heinz Marbaise
> Priority: Trivial
> Fix For: 3.6.0
>
>
> It looks like [this
> commit|https://github.com/apache/maven/commit/b8c06e61ab73cd9e25a5b2c93d9e5077b2196751]
> removed Guava imports from the codebase, however, several dependencies are
> still declared in the POMs. This can be problematic for projects that embed
> Maven jars (see MNG-6306 for an example).
> I tried a local Maven build with guava dependencies removed and it appears to
> compile without issue. I'll submit a pull request with the relevant changes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
