[
https://issues.apache.org/jira/browse/MNG-6475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611389#comment-16611389
]
ASF GitHub Bot commented on MNG-6475:
-------------------------------------
philwebb opened a new pull request #182: [MNG-6475] Remove unused Guava
dependencies
URL: https://github.com/apache/maven/pull/182
Remove unused Guava dependencies from POM files.
- [X] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line
and body.
- [X] Format the pull request title like `[MNG-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MNG-XXX` with the appropriate JIRA issue. Best
practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [X] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [X] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
[core-its]: https://maven.apache.org/core-its/core-it-suite/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove guava dependencies
> -------------------------
>
> Key: MNG-6475
> URL: https://issues.apache.org/jira/browse/MNG-6475
> Project: Maven
> Issue Type: Task
> Reporter: Phillip Webb
> Priority: Trivial
>
> It looks like [this
> commit|https://github.com/apache/maven/commit/b8c06e61ab73cd9e25a5b2c93d9e5077b2196751]
> removed Guava imports from the codebase, however, several dependencies are
> still declared in the POMs. This can be problematic for projects that embed
> Maven jars (see MNG-6306 for an example).
> I tried a local Maven build with guava dependencies removed and it appears to
> compile without issue. I'll submit a pull request with the relevant changes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
