michael-o commented on a change in pull request #84: sonar: fix possible NPE,
same fix of svn/git provider
URL: https://github.com/apache/maven-scm/pull/84#discussion_r209741988
##########
File path:
maven-scm-providers/maven-scm-provider-hg/src/main/java/org/apache/maven/scm/provider/hg/HgScmProvider.java
##########
@@ -159,7 +159,12 @@ else if ( url.startsWith( "http" ) )
public ScmProviderRepository makeProviderScmRepository( File path )
throws ScmRepositoryException, UnknownRepositoryStructure
{
- if ( path == null || !path.isDirectory() )
+ if ( path == null )
+ {
+ throw new NullPointerException( "Path argument is null" );
Review comment:
Please say "path cannot be null".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
