[
https://issues.apache.org/jira/browse/MNG-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507833#comment-16507833
]
ASF GitHub Bot commented on MNG-6344:
-------------------------------------
mcculls commented on issue #169: [MNG-6344] Upgrade Guice to 4.2 wit AOP (cglib)
URL: https://github.com/apache/maven/pull/169#issuecomment-396177378
Maven doesn't export any of the `com.google.inject` or `org.aopalliance`
packages to plugins, so they're currently unable to take advantage of any AOP
features (although maven-core could if it wished). The only reason to switch to
the AOP build would be for the slightly faster reflection via CGLIB. Both CGLIB
and ASM are embedded under an internal package, so there shouldn't be any
clashes with other copies of these libraries on the classpath.
However because the AOP build leans on CGLIB and ASM for reflection then
it's affected more by recent JDK changes. For example while the latest release
works fine on JDK 9, it needs a bump to ASM 6.2 to work properly on JDK 10+
Given this, and because no plugins can use AOP until we export the packages
from maven-core's `extension.xml`, we've kept with the no-AOP version. That may
change if we want to start allowing AOP in plugins - but that's best done under
a separate feature request, rather than at the same time as a version bump.
HTH
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Upgrade Guice to 4.2.0
> ----------------------
>
> Key: MNG-6344
> URL: https://issues.apache.org/jira/browse/MNG-6344
> Project: Maven
> Issue Type: Dependency upgrade
> Affects Versions: 3.5.2
> Reporter: Sylwester Lachiewicz
> Assignee: Michael Osipov
> Priority: Minor
> Fix For: 3.5.4
>
>
> A new version is available from
> [https://github.com/google/guice/wiki/Guice41] (released in 2016) - we should
> consider update.
> While updating - Maven depends on Guice, but with removed AOP code.
> {code:java}
> org.apache.maven:maven-core:jar:3.5.3-SNAPSHOT
> \- com.google.inject:guice:jar:no_aop:4.0:compile
> \- aopalliance:aopalliance:jar:1.0:compile{code}
> This has impact on performance
> [https://github.com/google/guice/wiki/OptionalAOP]
> If we decide to keep no_aop version, probably dependency to aopalliance can
> be removed (4kb).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
