[
https://issues.apache.org/jira/browse/MNG-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507350#comment-16507350
]
ASF GitHub Bot commented on MNG-6344:
-------------------------------------
slachiewicz commented on issue #169: [MNG-6344] Upgrade Guice to 4.2 wit AOP
(cglib)
URL: https://github.com/apache/maven/pull/169#issuecomment-396041950
Based on [Guice optional
AOP](https://github.com/google/guice/wiki/OptionalAOP#optional-aop)
> In Guice 2.0 and later, AOP is optional. If your platform doesn't support
bytecode generation, you can download a version of Guice that doesn't include
AOP support. This is most useful for mobile platforms like Android. This
version also lacks fast reflection and line numbers in error messages. For this
reason, we recommend Guice+AOP even in applications that don't use method
interceptors.
Only risk I can see is inclusion of additional dependency to CGLIB and ASM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Upgrade Guice to 4.2.0
> ----------------------
>
> Key: MNG-6344
> URL: https://issues.apache.org/jira/browse/MNG-6344
> Project: Maven
> Issue Type: Dependency upgrade
> Affects Versions: 3.5.2
> Reporter: Sylwester Lachiewicz
> Assignee: Michael Osipov
> Priority: Minor
> Fix For: 3.5.4
>
>
> A new version is available from
> [https://github.com/google/guice/wiki/Guice41] (released in 2016) - we should
> consider update.
> While updating - Maven depends on Guice, but with removed AOP code.
> {code:java}
> org.apache.maven:maven-core:jar:3.5.3-SNAPSHOT
> \- com.google.inject:guice:jar:no_aop:4.0:compile
> \- aopalliance:aopalliance:jar:1.0:compile{code}
> This has impact on performance
> [https://github.com/google/guice/wiki/OptionalAOP]
> If we decide to keep no_aop version, probably dependency to aopalliance can
> be removed (4kb).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
