McFoggy commented on a change in pull request #74: [SCM-885] third
implementation
URL: https://github.com/apache/maven-scm/pull/74#discussion_r189780680
##########
File path:
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogCommand.java
##########
@@ -89,17 +97,28 @@ protected ChangeLogScmResult executeChangeLogCommand(
ChangeLogScmRequest reques
final String datePattern = request.getDatePattern();
return executeChangeLogCommand(
request.getScmRepository().getProviderRepository(), fileSet,
request.getStartDate(), request.getEndDate(),
request.getScmBranch(), datePattern, startVersion,
- endVersion, request.getLimit() );
+ endVersion, request.getLimit(), request.getRevision() );
Review comment:
which both? there are 10 parameters, 4 provided as variables, 6 as method
calls on request variable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
