[
https://issues.apache.org/jira/browse/MSKINS-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244496#comment-16244496
]
ASF GitHub Bot commented on MSKINS-137:
---------------------------------------
hboutemy commented on issue #1: MSKINS-137 Make the hamburger menu work with
the top-navigation ena…
URL: https://github.com/apache/maven-fluido-skin/pull/1#issuecomment-342916660
thanks fo the explanation: now I know what a hamburger menu is :)
To test, I understand that any rendering of the skin with a nav bar in a
little screen should be used: we already have a few when running "mvn -Prun-its
verify"
Then I checked hbase site: the hamburger menu was perfect. But with the
patch applied, there is a space added before the topbar: to me, the patch
breaks topbar positionning.
Please share a screenshot of the issue you get in hbase, then the result
once the patch fixes the issue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Enable "Hamburger menu" with top-nav only
> -----------------------------------------
>
> Key: MSKINS-137
> URL: https://issues.apache.org/jira/browse/MSKINS-137
> Project: Maven Skins
> Issue Type: Improvement
> Reporter: Josh Elser
>
> Revitalizing this old PR https://github.com/apache/maven-skins/pull/4
> Still an issue for us down in HBase. Changes seem to apply and have worked in
> local testing on the HBase site.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
