[
https://issues.apache.org/jira/browse/MSKINS-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243452#comment-16243452
]
ASF GitHub Bot commented on MSKINS-137:
---------------------------------------
hboutemy commented on issue #1: MSKINS-137 Make the hamburger menu work with
the top-navigation ena…
URL: https://github.com/apache/maven-fluido-skin/pull/1#issuecomment-342725018
Hi Josh,
Thank you for your help: I'm very interested to merge.
But I don't understand what this change does: can you describe a little bit
the issue (what a "hamburger menu" is)? Is there one existing IT that show
clearly the issue (then the fix)?
Sidenote: this is a generic topic with Skins, ie understanding html/css
changes. Any generic idea on how to describe an issue and a fix, between
"designer oriented" people (who are html/css experts) and "java dev" oriented
people (like Maven developpers, like me, who is not proficient at all with
modern html/css, who need to judge before merging...)
At least, I'm happy that Git migration already has given one great result:
more effective discussion on PRs (I could easily merge the PR locally and run
the ITs, but did not find where to look for improved "hamburger menus"... :) )
Regards,
Hervé
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Enable "Hamburger menu" with top-nav only
> -----------------------------------------
>
> Key: MSKINS-137
> URL: https://issues.apache.org/jira/browse/MSKINS-137
> Project: Maven Skins
> Issue Type: Improvement
> Reporter: Josh Elser
>
> Revitalizing this old PR https://github.com/apache/maven-skins/pull/4
> Still an issue for us down in HBase. Changes seem to apply and have worked in
> local testing on the HBase site.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
