[
https://issues.apache.org/jira/browse/SUREFIRE-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145102#comment-16145102
]
ASF GitHub Bot commented on SUREFIRE-1383:
------------------------------------------
Github user owenfarrell commented on the issue:
https://github.com/apache/maven-surefire/pull/157
@Tibor17 - IT569 does not **fail** when introducing my changes. But since
the test was written as a single lifecycle, it inadvertently uses the code I've
introduced in this PR ([see comment above](#issuecomment-312972256)).
The only changes to IT569 were to split the single lifecycle in to multiple
lifecycles. While there, I tried to clean up the test resources to match
current standards/conventions.
But those changes to IT569 were to preserve its named intent: run tests
from a dependency jar.
Looks like two options to me:
1. Leave PR as is with minimally modified IT569
2. Revert IT569 to original state, add a new version of IT569 which
executes in multiple lifecycles and delete IT1383 (as it would be entirely
redundant of IT569).
> dependenciesToScan Does Not Leverage Classpath Elements
> --------------------------------------------------------
>
> Key: SUREFIRE-1383
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1383
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
> Affects Versions: 2.20
> Reporter: Owen Farrell
> Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: scanned-dependencies-sample.zip
>
>
> The <dependenciesToScan> configuration attribute relies solely on installed
> artifacts. This is an issue when the targeted dependencies were built as part
> of the current session. The net result is that stale artifacts are used (i.e.
> if the dependency has changed since it was last installed) or the tests are
> not executed at all (if the dependency has not been previously installed.
> Attached is a sample project that illustrates this issue:
> Given I have a multi-module project
> And the first module built includes test classes as part of the project
> artifact
> And subsequent modules scan the first for unit tests to execute
> When I execute the _*test*_ goal (prior to any install)
> Then the build should succeed
> And tests should be executed with each module
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
