[ 
https://issues.apache.org/jira/browse/SUREFIRE-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145035#comment-16145035
 ] 

ASF GitHub Bot commented on SUREFIRE-1383:
------------------------------------------

Github user Tibor17 commented on the issue:

    https://github.com/apache/maven-surefire/pull/157
  
    @owenfarrell
    I built the project. It was ok but then I realized you modified IT 569 
which I do not like because this was a feature and I want to guarantee that old 
tests pass without modification and additionally I have to find out if our 
contributors mask some of their hidden errors. I or we have to find the root 
cause why 569 fails with your changes. We should debug your code and then fix 
it. The changes on 569 you have done are interesting but I prefer to add a new 
one very similar like "surefire-569-RunTestFromInstalledJar".


> dependenciesToScan Does Not Leverage Classpath Elements 
> --------------------------------------------------------
>
>                 Key: SUREFIRE-1383
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1383
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: Maven Surefire Plugin
>    Affects Versions: 2.20
>            Reporter: Owen Farrell
>            Assignee: Tibor Digana
>             Fix For: Backlog
>
>         Attachments: scanned-dependencies-sample.zip
>
>
> The <dependenciesToScan> configuration attribute relies solely on installed 
> artifacts. This is an issue when the targeted dependencies were built as part 
> of the current session. The net result is that stale artifacts are used (i.e. 
> if the dependency has changed since it was last installed) or the tests are 
> not executed at all (if the dependency has not been previously installed.
> Attached is a sample project that illustrates this issue:
> Given I have a multi-module project
>    And the first module built includes test classes as part of the project 
> artifact
>    And subsequent modules scan the first for unit tests to execute
> When I execute the _*test*_ goal (prior to any install)
> Then the build should succeed
>    And tests should be executed with each module



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to