[
https://issues.apache.org/jira/browse/MSHARED-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15807964#comment-15807964
]
Michael Osipov edited comment on MSHARED-609 at 1/7/17 7:04 PM:
----------------------------------------------------------------
* Exactly, I guess you have raised this with your network admin and he was too
stupid to understand his fault, didn't he? Is your IP range in 169.254.0.0/16?
I do not expect net ops to read source code, but rather RFCs and documentations.
* Refined my statement, It blocks every port above 60000 but below 16-bit
unsigned integer. A bug.
I am not judging your code as a contribution, but you have rather fixed the
wrong end, Maven only. I would rather consider this being a {{UrlValidator}}
flag:
{code}
new UrlValidator( UrlValidator.ALLOW_LOCAL_URLS |
UrlValidator.ALLOW_MDNS_HOSTNAMES ); // or ALLOW_LINK_LOCAL_URLS, etc.
{code}
Beneath, {{DomainValidator}} gets {{isValidLinkLocal...(String)}} and your are
done.
This would be reasonable.
was (Author: michael-o):
* Exactly, I guess you have raised this with your network admin and he was too
stupid to understand his fault, didn't he? Is your IP range in 169.254.0.0/16?
I do not expect net ops to read source code, but rather RFCs and documentations.
* Refined my statement, It blocks every port above 60000 but below 16-bit
unsigned integer. A bug.
I am not judging your code as a contribution, but you have rather fixed the
wrong end, Maven only. I would rather consider this being a {{UrlValidator}}
flag:
{code}
new UrlValidator( UrlValidator.ALLOW_LOCAL_URLS |
UrlValidator.ALLOW_MDNS_HOSTNAMES ); // or ALLOW_LINK_LOCAL_URLS, etc.
{code}
Beneath, {{DomainValidator}} gets {{isValidLinkedLocal...(String)}} and your
are done.
This would be reasonable.
> Partially revert MSHARED-429
> ----------------------------
>
> Key: MSHARED-609
> URL: https://issues.apache.org/jira/browse/MSHARED-609
> Project: Maven Shared Components
> Issue Type: Task
> Components: maven-reporting-impl
> Affects Versions: maven-reporting-impl 2.4
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Fix For: maven-reporting-impl 3.0
>
>
> MSHARED-429 introduced handling of hostnames endling with {{.local}} though
> they are invalid in the way they are used.
> Copied from the ticket:
> I'd seriously like to revert this partially for 3.0:
> * Your DNS setup is simply broken. {{.local}} is a reserved TLD for mDNS
> resolution. This is not meant to be used in private networks. Doing so breaks
> Avahi on Linux/FreeBSD, Bonjour on macOS and everything else using zeroconf.
> You should register a domain name and use subdomains on your private network
> (https://de.wikipedia.org/wiki/Zeroconf#Multicast_DNS).
> * It does not accept full 16-bit unsigned integer
> * You always have to update with the newest pattern in Commons Validator
> Local hostnames (unqualified) can be validated by passing an option/flag to
> the validator. The rest of the patch, missing TLDs, etc. are already in
> Commons Validator 1.5.1.
> We should not encourage bad setups.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
