[ 
https://issues.apache.org/jira/browse/MSHARED-429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15807609#comment-15807609
 ] 

Michael Osipov commented on MSHARED-429:
----------------------------------------

I'd seriously like to revert this partially for 3.0:

* Your DNS setup is simply broken. {{.local}} is a reserved TLD for mDNS 
resolution. This is not meant to be used in private networks. Doing so breaks 
Avahi on Linux/FreeBSD, Bonjour on macOS and everything else using zeroconf. 
You should register a domain name and use subdomains on your private network 
(https://de.wikipedia.org/wiki/Zeroconf#Multicast_DNS).
* It accepts ports > 16-bit unsigned integer
* You always have to update with the newest pattern in Commons Validator

Local hostnames (unqualified) can be validated by passing an option/flag to the 
validator. The rest of the patch, missing TLDs, etc. are already in Commons 
Validator 1.5.1.

> Supposedly invalid URLs are rendered as plain text
> --------------------------------------------------
>
>                 Key: MSHARED-429
>                 URL: https://issues.apache.org/jira/browse/MSHARED-429
>             Project: Maven Shared Components
>          Issue Type: Bug
>          Components: maven-reporting-impl
>    Affects Versions: maven-reporting-impl-2.3
>            Reporter: Jan Schultze
>            Assignee: Hervé Boutemy
>            Priority: Minor
>              Labels: patch
>             Fix For: maven-reporting-impl 2.4
>
>         Attachments: local_url_valitdation.patch
>
>
> org.apache.maven.reporting.AbstractMavenReportRenderer#linkPatternedText(String)
>  from org.apache.maven.shared::maven-reporting-impl validates URLs before 
> rendering. If the validation fails URLs are rendered as plain text. The class 
> uses an (in recent versions) deprecated UrlValidator from commons-validator 
> which considers unqualified (i.e. local) host names and fully qualified 
> domain names with a top level domain longer than 4 characters as invalid 
> (such as the special use domain .local or more recent TLDs as .academy and 
> .paris). This makes using maven sites in a private network with a .local top 
> level domain cumbersome as browsing (proprietary) dependencies site(s) 
> requires users to manually copy and paste the URL.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to