[ 
https://issues.apache.org/jira/browse/MNG-5910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392531#comment-15392531
 ] 

ASF GitHub Bot commented on MNG-5910:
-------------------------------------

Github user rajivpjs commented on a diff in the pull request:

    https://github.com/apache/maven/pull/88#discussion_r72126082
  
    --- Diff: 
maven-model-builder/src/test/resources/poms/factory/complexEmptyAndMissing.xml 
---
    @@ -31,21 +31,5 @@
                     <profile.file>activated-1</profile.file>
                 </properties>
             </profile>
    -        <profile>
    -            <id>another-two-conditions</id>
    -            <activation>
    -                <property>
    -                    <name>myproperty</name>
    -                    <value>test</value>
    -                </property>
    -                <file>
    -                   <exists>simple.xml</exists>
    -                    <missing>simple.xml</missing>
    -                </file>
    -            </activation>
    -            <properties>
    -                <profile.miss>activated-2</profile.miss>
    -            </properties>
    -        </profile>
         </profiles>
    --- End diff --
    
    Well spotted. Sorry, this was accidental. I will revert this change shortly.


> Using both {{exists}} and {{missing}} in the same {{file}} element should 
> lead to an exception
> ----------------------------------------------------------------------------------------------
>
>                 Key: MNG-5910
>                 URL: https://issues.apache.org/jira/browse/MNG-5910
>             Project: Maven
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 3.3.3
>            Reporter: Konrad Windszus
>
> Currently it is not clear from the POM reference 
> (https://maven.apache.org/pom.html#Activation), that the elements {{exists}} 
> and {{missing}} below {{file}} are mutually exclusive, because only 
> {{exists}} is considered if it is there (see also 
> https://github.com/apache/maven/blob/master/maven-model-builder/src/main/java/org/apache/maven/model/profile/activation/FileProfileActivator.java#L91).
>  Please make it clearer in the POM reference that not both of them should be 
> used at the same time and also throw an exception during build time if that 
> is the case (in the effective POM).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to