[
https://issues.apache.org/jira/browse/MSHARED-567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15368219#comment-15368219
]
Hervé Boutemy edited comment on MSHARED-567 at 7/8/16 7:09 PM:
---------------------------------------------------------------
while thinking at it, I see 2 reasonable options:
1. replace {{setToolchain( Toolchain toolchain )}} with {{setToolchain( Object
toolchain )}} and use reflection for the {{findTool(String)}} call
2. simply remove this method: honestly, for the calling code, instead of
{{setToolchain(..)}}, coding {code:java} if (toolchain == null ) { do with
shared-utils } else { do with toolchain } {code} is not so much different
and when I look at implementation, I see that the tool name has ".exe" added
before using toolchain, but it should not: I really fear the current code
simply does not work
option 2, ie simply removing this toolchain support, looks to be the right
solution to me
any objection?
was (Author: hboutemy):
while thinking at it, I see 2 reasonable options:
1. replace {{setToolchain( Toolchain toolchain )}} with {{setToolchain( Object
toolchain )}} and use reflection for the {{findTool(String)}} call
2. simply remove this method: honestly, for the calling code, instead of
{{setToolchain(..)}}, coding {{ if (toolchain == null ) { do with shared-utils
} else { do with toolchain } }} is not so much different
and when I look at implementation, I see that the tool name has ".exe" added
before using toolchain, but it should not: I really fear the current code
simply does not work
option 2, ie simply removing this toolchain support, looks to be the right
solution to me
any objection?
> remove dependency on Maven core
> -------------------------------
>
> Key: MSHARED-567
> URL: https://issues.apache.org/jira/browse/MSHARED-567
> Project: Maven Shared Components
> Issue Type: Wish
> Components: maven-shared-utils
> Affects Versions: maven-shared-utils-3.0.2
> Reporter: Hervé Boutemy
>
> while creating an API for java tool in MSHARED-304, Maven core's Toolchain
> API is used: this makes maven-shared-utils dependant on Maven core.
> Since maven-shared-utils is expected to be a fundamental utilities library,
> ideally which could replace plexus-utils, depending on Maven core will cause
> a chicken and egg issue, since Maven core should be able to use
> maven-shared-utils
> for example, I'm working on MSHARED-562 and this dependency makes me think
> that I cannot let the new code in maven-shared-utils and create a dependency
> from Maven core on maven-shared-utils...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
