[ 
https://issues.apache.org/jira/browse/MWAR-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186115#comment-15186115
 ] 

Michael Osipov commented on MWAR-367:
-------------------------------------

Hi Jörg, it might look insane but 2.x has been around for years, remove happens 
in major versions only. Pity is that virtually nobody reacted on MWAR-257 and 
even you did not reopen the issue a year ago when Karl Heinz closed it. Why?

Anyway, if you have strong feelings about this parameter, provide a sane 
algorithm how to properly merge {{dependentWarIncludes}} and overlay includes 
with minimal loss/overlapping (etc.) and the ITs for edge cases in a separate 
issue and I will happily review it. Additionally consider that this parameter 
does not carry {{default}} in its name and should not considered as such. If 
you want a {{defaultprojectDependentWarIncludes}}, the algorithm is pretty 
cheap here.

> Overlay removes /META-INF/context.xml
> -------------------------------------
>
>                 Key: MWAR-367
>                 URL: https://issues.apache.org/jira/browse/MWAR-367
>             Project: Maven WAR Plugin
>          Issue Type: Bug
>          Components: overlay
>    Affects Versions: 2.6
>            Reporter: Peter Rader
>            Assignee: Michael Osipov
>             Fix For: 3.0.0
>
>         Attachments: test.zip
>
>
> A /src/main/webapp/META-INF/context.xml in a overlay could not be included. 
> Even 
> <containerConfigXML>${project.basedir}/target/war/work/myoverlaygroup/myoverlayartifact/META-INF/context.xml</containerConfigXML>
>  
> is ignored.
> Usually having copyXML=true, tomcat should copy the context.xml to 
> /conf/Catalina/ but as long the xml is not part of the WAR i can not deploy 
> on an virgin tomcat.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to