[ 
https://issues.apache.org/jira/browse/MWAR-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185611#comment-15185611
 ] 

Michael Osipov commented on MWAR-367:
-------------------------------------

I have found the issue: The overlay is passed from the artifact dependencies as 
{{DefaultOverlay}} in {{OverlayManager#initialize}}. Unfortunately, the 
constructor receives {{defaultIncludes}} and {{defaultExcludes}} which are set 
with the values of {{dependentWarIncludes}} and {{dependentWarExcludes}} and 
they are by default different to those in {{Overlay}}. For now, uses this 
workaround: 
{{<dependentWarExcludes>META-INF/MANIFEST.MF</dependentWarExcludes>}}.

[~khmarbaise], since those attributes are deprecated, I am inclined to remove 
them completely from the {{OverlayManager}} because {{Overlay}} already comes 
with default excludes as well as the constructor {{DefaultOverlay(Artifact, 
String, String)}}.

> overlay removes /META-INF/context.xml
> -------------------------------------
>
>                 Key: MWAR-367
>                 URL: https://issues.apache.org/jira/browse/MWAR-367
>             Project: Maven WAR Plugin
>          Issue Type: Bug
>          Components: overlay
>    Affects Versions: 2.6
>            Reporter: Peter Rader
>            Priority: Blocker
>         Attachments: test.zip
>
>
> A /src/main/webapp/META-INF/context.xml in a overlay could not be included. 
> Even 
> <containerConfigXML>${project.basedir}/target/war/work/myoverlaygroup/myoverlayartifact/META-INF/context.xml</containerConfigXML>
>  
> is ignored.
> Usually having copyXML=true, tomcat should copy the context.xml to 
> /conf/Catalina/ but as long the xml is not part of the WAR i can not deploy 
> on an virgin tomcat.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to