[
https://issues.apache.org/jira/browse/MPIR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679150#comment-14679150
]
Michael Osipov edited comment on MPIR-234 at 8/9/15 1:48 PM:
-------------------------------------------------------------
Would that actually work with Gitweb? Look how Gitweb creates browsable URLs:
https://git-wip-us.apache.org/repos/asf?p=maven.git;a=tree;f=maven-compat
Hervé, I like your simple idea but I do not think that SCM handling should be
in the core at all. Core is responsible for building and not SCM-related stuff.
Who uses SCM information? MREALEASE (+ MSCM) and MSITE + reporting plugins. If
so, they should handle this. I would favor some (build) extension which is
plugged into core which properly calculates SCM anon/dev URLs as well as web
URL. Additionally, a separate improvement which can properly calculate a site
URL (not related to SCM imho). Maven can be shipped with Git and Subverion
extensions by default.
was (Author: michael-o):
Would that actually work with Gitweb? Look how Gitweb creates browsable URLs:
https://git-wip-us.apache.org/repos/asf?p=maven.git;a=tree;f=maven-compat
Hervé, I like your simple idea but I do not think that SCM handling should be
in the core at all. Core is responsible for building and not SCM-related stuff.
Who uses SCM information? MREALEASE (+ MSCM) and MSITE + reporting plugins. If
so, they should handle this. I would favor some (build) extension which is
plugged into core which properly calculates SCM anon/dev URLs as well as web
URL. Additionally, a separate improvement which can properly calculate a site
URL (not related to SCM imho).
> SCM-link in site of multimodule projects should not append module name by
> default (at least for git)
> ----------------------------------------------------------------------------------------------------
>
> Key: MPIR-234
> URL: https://issues.apache.org/jira/browse/MPIR-234
> Project: Maven Project Info Reports Plugin
> Issue Type: Bug
> Components: scm
> Affects Versions: 2.4
> Reporter: Mirko Friedenhagen
>
> I have setup a simple multi module project (see
> https://github.com/mfriedenhagen/multi-module-sample/tree/multi-site-complex)
> which uses git on github as {{scm}}. While rendering the site, MPIR will by
> default add the name of the module to the SCM-URLs in source-repository.html.
> So instead of https://github.com/mfriedenhagen/multi-module-sample/ I see
> https://github.com/mfriedenhagen/multi-module-sample/core/,
> g...@github.com:mfriedenhagen/multi-module-sample.git/core and
> git://github.com/mfriedenhagen/multi-module-sample.git/core in the report for
> the core module. All these URLs are invalid. For SVN this could be assumed to
> be the right behaviour, for git and probably other SCMs this is not true. As
> a workaround I have to reconfigure the scm section (see
> https://github.com/mfriedenhagen/multi-module-sample/blob/multi-site-complex/core/pom.xml)
> in the modules like this:
> {code:xml}
> <scm>
> <connection>${project.parent.scm.connection}</connection>
>
> <developerConnection>${project.parent.scm.developerConnection}</developerConnection>
> <url>${project.parent.scm.url}</url>
> </scm>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
