[ http://jira.codehaus.org/browse/MCHECKSTYLE-49?page=comments#action_70565 ] Maria Odea Ching commented on MCHECKSTYLE-49: ---------------------------------------------
Review comments by Stephen Duncan (from Maven Dev List): ----- On the "Multimodule Configuration" documentation: As I just mentioned on a question on the user's list, I don't think it's correct to specify the "build-tools" dependency as a dependency of the plugin. While this will work if you manually install the build-tools jar, it will not download it from an internal repository. It should instead be specified as build extension like in the "Using Custom Developed Chechstyle Check Modules" example. (Also not the spelling mistake in that title: ChecHstyle). Because this is somewhat confusing, I think it should mentioned either in the "Using a Custom Checkstyle Checker Configuration" as a way of using a classpath reference, or it should be it's own guide on using a shared jar for configuration. - Stephen > Review and revise plugin documentation > -------------------------------------- > > Key: MCHECKSTYLE-49 > URL: http://jira.codehaus.org/browse/MCHECKSTYLE-49 > Project: Maven 2.x Checkstyle Plugin > Issue Type: Task > Reporter: Maria Odea Ching > Assigned To: Maria Odea Ching > Attachments: documentation.patch > > Original Estimate: 22 hours > Time Spent: 22 hours > Remaining Estimate: 0 minutes > -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
