[ http://jira.codehaus.org/browse/MCHECKSTYLE-49?page=comments#action_70564 
] 
            
Maria Odea Ching commented on MCHECKSTYLE-49:
---------------------------------------------

Review comments by Vincent Siveton (from Maven Dev List):

------
here my comments:

usage.html
Should be better to create two subsections:
- Generate the report as part of Project Reports
- Generate the report as standalone

Maybe add a report screenshot

FAQ
"checkstyle.properties" or "checkstyle properties" (with space)
If the first, the following seems wrong according the doc
<configLocation>checkstyle.properties</configLocation>
http://people.apache.org/~oching/maven-checkstyle-plugin/checkstyle-mojo.html#configLocation

custom-property-expansion.html
propertiesLocation has no sample. Is is the same explained in FAQ?

multi-module-config.html
Review it as said
Replace unix commands by a directory layout:
whizbang
|-- pom.xml
`-- src
   |-- main
...

Cheers,

Vincent


> Review and revise plugin documentation
> --------------------------------------
>
>                 Key: MCHECKSTYLE-49
>                 URL: http://jira.codehaus.org/browse/MCHECKSTYLE-49
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Task
>            Reporter: Maria Odea Ching
>         Assigned To: Maria Odea Ching
>         Attachments: documentation.patch
>
>   Original Estimate: 22 hours
>          Time Spent: 22 hours
>  Remaining Estimate: 0 minutes
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to