[ http://jira.codehaus.org/browse/MSUREFIRE-131?page=comments#action_66985
]
Bryce Nordgren commented on MSUREFIRE-131:
------------------------------------------
I think I just ran into this as well but didn't know how to phrase the
question. I'm trying to make a maven2 POM for the jakarta commons-events
project (which is dormant.) Their naming convention is a little askew, so I
tried to add an {{<includes/>}} element to explicitly specify the
"AllTestsSuite.java" which constructs a gigantic TestSuite. {{mvn test}} just
results in a "No tests to run" complaint. Removing the includes element and
renaming the file to end in "Test.java" makes maven find the test and complete
without error. I'll try this patch and see if it cures my ills, then report
back.
> Surefire-JUnit does not recognize "suite"-methods
> -------------------------------------------------
>
> Key: MSUREFIRE-131
> URL: http://jira.codehaus.org/browse/MSUREFIRE-131
> Project: Maven 2.x Surefire Plugin
> Type: Bug
> Versions: 2.2
> Reporter: Philip Gerlach
> Attachments: maven-surefire-junit-trunk-412516.patch
>
>
> Since Surefire-JUnit doesn't support JUnit4 yet, i tried to use a
> "suite"-method like
> ------
> public static junit.framework.Test suite() {
> return new junit.framework.JUnit4TestAdapter(Foo.class);
> }
> -----
> to run it, but Surefire-JUnit did not recognize these methods and treated
> them like PojoTests what obviously lead to TestFailures.
> So I fetched the source code from the repository and searched for the
> problem. I found two if-conditons in JUnitTestSet and JUnitDirectoryTestSuite
> that did not test for the "suite"-mechanism, so I wrote a new static method
> to test for this situation and integrated it in the if-conditions.
> Now the "suite"-methods work for my JUnit4 Tests and should do also for
> others ;-)
> The patch is attached.
> P.S. Since this it is the first time, I'm trying to bugfix something for an
> open source-project, please just let me know, if I have done something wrong
> with this process.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
