romseygeek commented on code in PR #16832:
URL: https://github.com/apache/lucene/pull/16832#discussion_r4312657991
##########
lucene/core/src/test/org/apache/lucene/codecs/lucene90/TestLucene90DocValuesFormat.java:
##########
@@ -1394,4 +1396,65 @@ public IndexInput slice(String sliceDescription, long
offset, long length) {
}
}
}
+
+ public void testReuseAddressUpper() throws Exception {
Review Comment:
Does this test fail if your changes aren't made? If I'm reading it
correctly you're loading data more efficiently but there isn't any change in
behaviour, right? So I don't think the test really adds anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
