hidingmyname opened a new issue, #16824:
URL: https://github.com/apache/lucene/issues/16824

   ### Description
   
   **Location** (lucene @ main f94888d85c1): 
`lucene/suggest/src/java/org/apache/lucene/search/suggest/DocumentDictionary.java:126`
   
   **Current text**
   ```
   <code>withPayload</code> to false, implies ...
   ```
   
   **Problem**: The constructor parameter is named `hasPayloads`.
   
   **Suggested fix**: <code>hasPayloads</code> to false, implies ...
   
   ```diff
   --- 
a/lucene/suggest/src/java/org/apache/lucene/search/suggest/DocumentDictionary.java
   +++ 
b/lucene/suggest/src/java/org/apache/lucene/search/suggest/DocumentDictionary.java
   @@ -124,5 +124,5 @@
        /**
         * Creates an iterator over term, weight and payload fields from the 
lucene index. setting
   -     * <code>withPayload</code> to false, implies an iterator over only 
term and weight.
   +     * <code>hasPayloads</code> to false, implies an iterator over only 
term and weight.
         */
        public DocumentInputIterator(boolean hasPayloads, boolean hasContexts) 
throws IOException {
   ```
   
   **Already fixed in Lucene.NET**: apache/lucenenet@9a6f97343
   
   **How Lucene.NET fixed it**: commit `9a6f9734347` (2016-09-16) "Updated 
Suggest documentation links to code elements and made corrections.", file 
`src/Lucene.Net.Suggest/Suggest/DocumentDictionary.cs`
   
   ```diff
   @@ -127,7 +127,7 @@ protected internal class DocumentInputIterator : 
IInputIterator
    
                /// <summary>
                /// Creates an iterator over term, weight and payload fields 
from the lucene
   -            /// index. setting <code>withPayload</code> to false, implies 
an iterator
   +            /// index. setting <see cref="HasPayloads"/> to false, implies 
an iterator
                /// over only term and weight.
                /// </summary>
                public DocumentInputIterator(DocumentDictionary outerInstance, 
bool hasPayloads, bool hasContexts)
   ```
   
   I can submit a PR for this.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to