javanna commented on code in PR #16805:
URL: https://github.com/apache/lucene/pull/16805#discussion_r4247394445
##########
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##########
@@ -624,26 +624,6 @@ public TopDocs search(Query query, int n) throws
IOException {
return searchAfter(null, query, n);
}
- /**
- * Lower-level search API.
- *
- * <p>{@link LeafCollector#collect(int)} is called for every matching
document.
- *
- * @throws TooManyClauses If a query would exceed {@link
IndexSearcher#getMaxClauseCount()}
- * clauses.
- * @deprecated This method is being deprecated in favor of {@link
IndexSearcher#search(Query,
- * CollectorManager)} due to its support for concurrency in IndexSearcher
- */
- @Deprecated
- public void search(Query query, Collector collector) throws IOException {
- query = rewrite(query, collector.scoreMode().needsScores());
- Weight weight = createWeight(query, collector.scoreMode(), 1);
- collector.setWeight(weight);
- for (LeafReaderContext ctx : leafContexts) { // search each subreader
- searchLeaf(ctx, 0, DocIdSetIterator.NO_MORE_DOCS, weight, collector);
- }
Review Comment:
thanks for looking into this! It'll be great to finally remove this method!
Just a placeholder that if we remove it as part of this change, we should
add an entry to the migrate guide as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
