Pulkitg64 commented on code in PR #16764:
URL: https://github.com/apache/lucene/pull/16764#discussion_r4186065114
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene104/Lucene104ScalarQuantizedVectorsWriter.java:
##########
@@ -642,7 +643,7 @@ static int calculateCentroid(MergeState mergeState,
FieldInfo fieldInfo, float[]
for (int i = 0; i < mergeState.knnVectorsReaders.length; i++) {
KnnVectorsReader knnVectorsReader = mergeState.knnVectorsReaders[i];
if (knnVectorsReader == null) continue;
- count += accumulateCentroid(knnVectorsReader, fieldInfo, centroid);
+ count += accumulateCentroid(knnVectorsReader, fieldInfo,
mergeState.liveDocs[i], centroid);
Review Comment:
> Right, looks like this comment needs to be removed now. We fixed two bugs
in one go :)
Wow!! Nicee!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
