michaeljmarshall commented on PR #16747: URL: https://github.com/apache/lucene/pull/16747#issuecomment-5914627368
The main argument against back porting this bug fix is that calling `advance()` or `nextDoc()` on an iterator after it already returned NO_MORE_DOCS is documented as being undefined. My main thinking was that the fact that a passed in iterator is not advanced to `NO_MORE_DOCS` is itself a bug. I had an agent review the lucene code base and it couldn't find any incorrect usages (doesn't mean there aren't any). As such, I can see an argument for merging or closing without merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
