ChrisHegarty commented on code in PR #16684:
URL: https://github.com/apache/lucene/pull/16684#discussion_r4144309582
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsReader.java:
##########
@@ -253,9 +272,12 @@ private void ensureOpen() throws AlreadyClosedException {
/** Close the underlying {@link IndexInput}s. */
@Override
- public void close() throws IOException {
+ public synchronized void close() throws IOException {
Review Comment:
You might want to avoid making this whole method synchronized, and just
synchronize over the field access ( similar to
https://github.com/apache/lucene/pull/16749#discussion_r4144167001)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
