ChrisHegarty commented on code in PR #16749:
URL: https://github.com/apache/lucene/pull/16749#discussion_r4143501057
##########
lucene/core/src/java/org/apache/lucene/store/IOContext.java:
##########
@@ -66,11 +66,19 @@ interface FileOpenHint {}
/** Returns an {@link IOContext} for merging with the specified {@link
MergeInfo} */
static IOContext merge(MergeInfo mergeInfo) {
+ Objects.requireNonNull(mergeInfo);
return merge(mergeInfo, Set.of());
}
+ /**
+ * Returns an {@link IOContext} for merging, for a caller that knows a merge
reads the file but
+ * not how large the merge is.
Review Comment:
```suggestion
* Returns an {@link IOContext} for merging when the caller does not know
how large the merge
* is. Unlike {@link #merge(MergeInfo)}, {@link #mergeInfo()} on the
returned context is {@code
* null}.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
