kkewwei commented on PR #16733: URL: https://github.com/apache/lucene/pull/16733#issuecomment-5908898183
I realized that this optimization is not safe from a performance perspective for `TOP_SCORES`. The existing path wraps the filter-only conjunction in a `ConstantScoreScorer` with a score of 0. Once `TopScoreDocCollector` exceeds totalHitsThreshold, it raises the minimum competitive score above 0, causing `ConstantScoreScorer` to replace its delegate with DocIdSetIterator.empty() and terminate immediately. Due to the`DocIdSetIterator.empty() `, the gains from modifications are relatively small, so I will close the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
