kaivalnp commented on code in PR #16706:
URL: https://github.com/apache/lucene/pull/16706#discussion_r4137176234
##########
lucene/sandbox/src/java/org/apache/lucene/sandbox/codecs/dedup/DedupUtil.java:
##########
@@ -146,7 +145,11 @@ record ReadFieldInfo(
int vectorCount,
OrdToDocDISIReaderConfiguration ordToDoc,
long fieldOrdToGroupOrdOffset,
- long fieldOrdToGroupOrdSize) {
+ long fieldOrdToGroupOrdSize,
+ // Bits used to pack each entry of the fieldOrdToGroupOrd array (a group
ordinal); named to
+ // match its sibling fieldOrdToGroupOrd* fields, referred to as
groupOrdBitsPerValue
+ // elsewhere.
Review Comment:
Unnecessary comment?
Can we also use a consistent name everywhere, maybe
`fieldOrdToGroupOrdBitsPerValue`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
