gf2121 commented on PR #16089: URL: https://github.com/apache/lucene/pull/16089#issuecomment-5890132112
Thank you, and sorry for the late reply! I initially assumed that 1D range queries on BKD trees would always match a contiguous run of leaf blocks, and that a single `visitor#grow` call would suffice. After reconsidering, I realized there are cases where grow is called multiple times — specifically, in the worst case it is called `2 * log N` times (where N is the number of leaf blocks), as illustrated in the diagram below. <img width="3819" height="1323" alt="image" src="https://github.com/user-attachments/assets/13b99448-7baa-4bcc-ab3c-0f301dc7e57e"; /> The change looks good to me. I'll merge it tomorrow unless someone beats me to it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
