mayya-sharipova opened a new pull request, #16734: URL: https://github.com/apache/lucene/pull/16734
Builds on #16708, which added validation. Vector columns declared DENSE now go through a bulk path, and those checks come along with it via a validating cursor, so addBatch keeps rejecting what addDocument rejects. Column API: - Add VectorValuesCursor<T>, a values cursor for DENSE columns modeled on LongValuesCursor. - Add VectorColumn.values(). Indexing chain: - Vector columns declared DENSE are handed to the writer in a single addDenseValues call. The dense count and the cursor's dimension are checked once per batch instead of per vector. - ValidatingVectorValuesCursor runs the #16708 checks as the writer consumes vectors. - ColumnValidation gains offset-based variants of the value checks and checkVectorCursorDimension. Codec API: - Add KnnFieldVectorsWriter.addDenseValues, which defaults to calling addValue once per vector. ### Description <!-- If this is your first contribution to Lucene, please make sure you have reviewed the contribution guide. https://github.com/apache/lucene/blob/main/CONTRIBUTING.md --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
