dweiss commented on code in PR #16714:
URL: https://github.com/apache/lucene/pull/16714#discussion_r4125415800
##########
lucene/core/src/java/org/apache/lucene/search/SortedSetSelector.java:
##########
@@ -296,6 +298,7 @@ public long cost() {
@Override
public void intoBitSet(int upTo, FixedBitSet bitSet, int offset) throws
IOException {
in.intoBitSet(upTo, bitSet, offset);
+ setOrd();
Review Comment:
Some tests assume singleton doc value views - this wasn't true for
SimpleText (and isn't required in general). If you revert this patch and rerun
the test repro given in the description, it'll fail every time on that test's
expectations. I think it's fine to make SimpleText consistent with other codecs
here - if doc values are indeed singletons, return a corresponding singleton
view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
