john-mlika commented on code in PR #16696:
URL: https://github.com/apache/lucene/pull/16696#discussion_r4067459457
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsWriter.java:
##########
@@ -417,7 +425,17 @@ private void reconstructAndWriteNeighbours(
@Override
public IORunnable mergeOneField(FieldInfo fieldInfo, MergeState mergeState)
throws IOException {
- flatVectorWriter.mergeOneFlatVectorField(fieldInfo, mergeState);
+ MergeScorerData mergeScorerData =
+ flatVectorWriter.mergeOneFlatVectorFieldForMergeScorer(
+ fieldInfo, mergeState, this::buildsGraph);
+ if (mergeScorerData != null) {
+ try {
+ preparedMergeScorers.add(mergeScorerData);
Review Comment:
codex flagged that this can OOM when the list grows internally
in hindsight this is overkill and done nowhere else i could find. it's
probably best to let it throw and be handled by IndexWriter like any other
merge error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
