kaivalnp commented on PR #15784: URL: https://github.com/apache/lucene/pull/15784#issuecomment-5543754118
Apologies for the trouble this caused, it was a miss from my side! I guess my reasoning behind making this change at the time was: - The feature is "find all vectors above `resultSimilarity`", and `traversalSimilarity` is an implementation-specific knob to tune quality v/s performance (which is being replaced with something, albeit subjectively, easier to tune + more performant). - The queries are marked [`@lucene.experimental`](https://github.com/apache/lucene/blob/553fb33c0ef7c5e6d54ed4f35b966d95cb6535a9/build-tools/build-infra/src/main/java/org/apache/lucene/gradle/plugins/java/RenderJavadocPlugin.java#L502), allowing changes to be backwards incompatible ([1](https://github.com/apache/lucene/issues/16392#issuecomment-4972594641), [2](https://github.com/apache/lucene/issues/9652#issuecomment-1223917590), [3](https://github.com/apache/lucene/issues/13831#issuecomment-2388012865), etc.) In retrospect, having one release where the constructor was marked deprecated, and the "new feature" being exposed with a different public-facing API (like a new class, or static method like `FloatVectorSimilarity.newAdaptiveQuery`) would've been better. > As things stand now, you can't even "re-add" the old classes back in to a 10.5.x or a 10.6 release Given that Lucene 10.5.2 bugfix is in process, I wonder if we can re-add the old collector from 10.4 and expose a new deprecated static method (say `FloatVectorSimilarity.legacyQuery`) for users that discover this incompatible change, and can continue with the old behavior without copying the class outside Lucene, like you had to. Happy to create this PR if you and the release manager feel it is worth adding^ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
