hossman commented on issue #16573: URL: https://github.com/apache/lucene/issues/16573#issuecomment-5529638682
> Also I'm not sure that https://github.com/apache/lucene/pull/15760 is buying anything at all when an IndexOrDocValues query is used. ... +1 > I think the PR could just be reverted probably... +1 The existence of `NumericFieldStats.getStats()` feels intrinsically like a trap for developers. If there are long term plans for why it makes sense to to have this as a general utility class so be it -- but then the names of the (public) functions should be very explicit: `NumericFieldStats.getStatsFromPoints` vs `NumericFieldStats.getStatsFromDocValuesSkipper` But if the *only* caller for any `NumericFieldStats` methods are `SortedNumericDocValuesRangeQuery` -- then put the logic back in a private method in `SortedNumericDocValuesRangeQuery` until such time as multiple callers exist. The one change i would suggest over a simple "revert the original PR" is the _addition_ of robust range query tests using floats & doubles (like in my attached patch, or in the proposed PR #16575) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
