john-mlika commented on PR #16619: URL: https://github.com/apache/lucene/pull/16619#issuecomment-5513630398
thanks btw, it's only slice() that stopped reading at creation. clone() still positions eagerly at the parent's file pointer, i left it since clones seem to usually be read anyway, it was the slices that were being created and dropped. in my head, making clone() lazy would mean maintaining the parent's position and seeking to it on the first read, instead of just maintaining where the slice starts. could add it as a followup though, wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
