uschindler commented on PR #16585: URL: https://github.com/apache/lucene/pull/16585#issuecomment-5506331880
> > > "the application embedding it" ~~ "the application in which it is embedded" is how I was finally able to parse it > > > I don't undertstand that comment, Should I change it or is the current text ok? It is obvious if you read the previous sentence. > > Yes it's fine, sorry to confuse the issue. I was just suggesting a possible alternative, that to me, is clearer. But either way is fine. The sentence before has "downstream application" in its description, I could replace "embedding application" by "downstream application". This would not change structure of sentence (I don't like yours its harder for me to read). What do you think? I am planning to merge this tomorrow (after 72 hours) to allow others to review. After that I will proceed with open security issues and comment to reporter with a reference to this file. Actually at moment there is only one open one which is long overdue, so this is why I want to hurry up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
