zhaih commented on PR #16416: URL: https://github.com/apache/lucene/pull/16416#issuecomment-5344886574
Sure no problem, happy to review, I will take a look soon On Wed, Aug 19, 2026, 08:49 Luiz Anselmo ***@***.***> wrote: > *luizmlima* left a comment (apache/lucene#16416) > <https://github.com/apache/lucene/pull/16416#issuecomment-5344550364> > > Hi @zhaih <https://github.com/zhaih>, sorry for the ping. > > I noticed that you've previously reviewed and merged changes in the > Kuromoji module, so I thought you might be a good person to ask for > feedback on this PR. > > This change replaces the ArrayList currently used as a FIFO buffer in > JapaneseCompletionFilter.CompletionTokenGenerator with an ArrayDeque, > avoiding remove(0) and using addLast() / removeFirst() instead. > > I've also added JMH benchmark results and additional validation details to > the PR. The change does not affect the public API or the generated tokens, > ordering, offsets, or position increments. > > If you have a chance to take a look, I'd really appreciate your feedback > on whether this change makes sense for Lucene. > > Thanks! > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/lucene/pull/16416?email_source=notifications&email_token=AEFSB7BIRJUK5ED54OA5YS35KXEADA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMZUGQ2TKMBTGY2KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-5344550364>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AEFSB7GFVDDQF5YIBJJM67T5KXEADAVCNFSNUABFKJSXA33TNF2G64TZHMZTIMJWGMYTGNJQHNEXG43VMU5TIOJVGYYTANRRHE42C5QC> > . > Triage notifications, keep track of coding agent tasks and review pull > requests on the go with GitHub Mobile for iOS > <https://github.com/notifications/mobile/ios/AEFSB7FLHKJITJV2QXAYJDL5KXEADA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMZUGQ2TKMBTGY2KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y> > and Android > <https://github.com/notifications/mobile/android/AEFSB7CPMFUYXNFT7K44L235KXEADA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMZUGQ2TKMBTGY2KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>. > Download it today! > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
