jeho-rpls commented on code in PR #16368: URL: https://github.com/apache/lucene/pull/16368#discussion_r3580651709
########## lucene/core/src/java/org/apache/lucene/util/hnsw/HnswConcurrentMergeBuilder.java: ########## Review Comment: Thanks for the question :) No. The abort check throws `MergeAbortedException` inside the workers. `TaskExecutor#invokeAll` then cancels the remaining tasks, waits for the running ones to settle, and rethrows the first exception. So `build()` exits at the `invokeAll` call and never reaches the "merge completed" line. Each running worker also stops at its own next node insertion since they all share the same check. With InfoStream enabled, an aborted concurrent merge logs only the initial "build graph" line. `testRollbackDuringConcurrentMerge` in this PR exercises the abort path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
