markrmiller commented on PR #16204: URL: https://github.com/apache/lucene/pull/16204#issuecomment-4962713850
I've intended to come back to it, but I'm currently in London / Italy for the next two weeks on vacation. After posting this PR, I was pointed to a previous, abandoned, closed PR that attempted essentially the same thing, but it was closed as it appeared to show worse performance in the attempted benchmarks - however, those benchmarks appear to have been done without enough heap and so it was thrashing and I believe you get worse performance in that case because the little check that avoids unnecessary system calls never gets to kick in. As that PR noted though, it was done before the bulk API landed and here I've made it opt in - so if you are heap constrained enough that it's going to thrash, you don't have to use it. With a large enough heap it appears to be a pretty large win. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
