msokolov commented on code in PR #16383:
URL: https://github.com/apache/lucene/pull/16383#discussion_r3572260750
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsWriter.java:
##########
@@ -714,6 +715,15 @@ static FieldWriter<?> create(
beamWidth,
infoStream,
tinySegmentsThreshold);
+ case FLOAT16 ->
Review Comment:
OK I just realized -- we should not be adding a writer method to an existing
codec, because this will create a scenario where we can write an index with an
older codec version (104?) that cannot be read by other versions of Lucene that
have the 104 readers without fp16 support. When we add a new file format, we
need a new Codec version, don't we?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
